Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArmoredChat v3 (DomainChat) #1261

Closed

Conversation

Changed name.
@Armored-Dragon Armored-Dragon added bug Something isn't working enhancement New feature or request work in progress Do not merge yet labels Nov 30, 2024
@Armored-Dragon Armored-Dragon self-assigned this Nov 30, 2024
@Armored-Dragon Armored-Dragon added needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested and removed work in progress Do not merge yet labels Dec 31, 2024
@Armored-Dragon Armored-Dragon marked this pull request as ready for review December 31, 2024 22:27
@ksuprynowicz

This comment was marked as resolved.

@ksuprynowicz

This comment was marked as resolved.

@ksuprynowicz
Copy link
Member

The new chat also seems to forget settings for me on every restart.

@Armored-Dragon
Copy link
Member Author

It would also be really good to have "Copy URL to clipboard" button next to URL - it would be especially useful in VR

I won't be adding any additional features to this pull request, I will absolutely look into adding this feature in a different pull request!

@Armored-Dragon
Copy link
Member Author

The new chat also seems to forget settings for me on every restart.

I can not replicate this issue. Could you provide more information about what is going on? Are there any errors in the logs about JSON parsing failures or anything like that?

@ksuprynowicz

This comment was marked as resolved.

@Armored-Dragon
Copy link
Member Author

I have hidden the video embed functionality due to it not working as elegantly as I would like it to. I will reactivate it once I have a more elegant implementation and a dedicated video player widget.

Added debug logs.
Don't save settings when initializing the application.
@Armored-Dragon
Copy link
Member Author

I have also added several debugging prints to the code which should hopefully help diagnose the issue @ksuprynowicz was having.

@Armored-Dragon

This comment was marked as outdated.

@Armored-Dragon Armored-Dragon added the work in progress Do not merge yet label Jan 18, 2025
@Armored-Dragon Armored-Dragon removed the work in progress Do not merge yet label Jan 28, 2025
@Krzeszny
Copy link

Krzeszny commented Feb 8, 2025

Chat doesn't wrap in this build (if the message is too long)

@Armored-Dragon
Copy link
Member Author

Chat doesn't wrap in this build (if the message is too long)

Are you running the lastest build of this PR? This should have been fixed with this commit.

@Krzeszny
Copy link

Krzeszny commented Feb 10, 2025

Are you running the lastest build of this PR? This should have been fixed with this commit.

No, I'm running build dbf5af0. Where do I get the latest one? How do I download it?

This reverts commit 6cc11fd.
@Armored-Dragon
Copy link
Member Author

Closed in favor of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment