-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArmoredChat v3 (DomainChat) #1261
ArmoredChat v3 (DomainChat) #1261
Conversation
Changed name.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
The new chat also seems to forget settings for me on every restart. |
I won't be adding any additional features to this pull request, I will absolutely look into adding this feature in a different pull request! |
I can not replicate this issue. Could you provide more information about what is going on? Are there any errors in the logs about JSON parsing failures or anything like that? |
This comment was marked as resolved.
This comment was marked as resolved.
I have hidden the video embed functionality due to it not working as elegantly as I would like it to. I will reactivate it once I have a more elegant implementation and a dedicated video player widget. |
Added debug logs. Don't save settings when initializing the application.
I have also added several debugging prints to the code which should hopefully help diagnose the issue @ksuprynowicz was having. |
This comment was marked as outdated.
This comment was marked as outdated.
Remove unused video embed code.
Chat doesn't wrap in this build (if the message is too long) |
Are you running the lastest build of this PR? This should have been fixed with this commit. |
No, I'm running build dbf5af0. Where do I get the latest one? How do I download it? |
This reverts commit 6cc11fd.
Closed in favor of |
Major overhaul to the existing chat system.
TODO:
LATER: (will be fixed in a future PR)
Typing indicator #1161
[ ArmoredChat.js ] Chat messages should show the message in 3D space near the avatar #1147
[ ArmoredChat.js ] Translation support #1148
[ ArmoredChat.js ] Embeded videos #1166
Fixes #1183
Closes #1252
Closes #1253
Fixes #1256
Fixes #1255
Closes #1258
Closes #1254